[Bugfix] The "send" button for chat should be enabled for logged in users #2202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamelafox
reviewed
Dec 1, 2024
|
|
||
| const disableRequiredAccessControl = requireLogin && !loggedIn; | ||
| const sendQuestionDisabled = disabled || !question.trim() || requireLogin; | ||
| const sendQuestionDisabled = disabled || !question.trim(); |
There was a problem hiding this comment.
Hm, I wonder if it would make more sense to have || disableRequiredAccessControl? Would that also resolve the bug, since it should only be true when not logged in.
It's not a difference security-wise, since a logged out user will fail the authentication check on the server-side, but it'd make sense visually/for screen readers, I think.
pamelafox
reviewed
Dec 2, 2024
|
|
||
| const disableRequiredAccessControl = requireLogin && !loggedIn; | ||
| const sendQuestionDisabled = disabled || !question.trim() || requireLogin; | ||
| const sendQuestionDisabled = disabled || !question.trim() || disableRequiredAccessControl; |
There was a problem hiding this comment.
I added "disableRequiredAccessControl" to this boolean condition, to align the textfield and button disabled state.
pamelafox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Currently, the send button is disabled when login is required, even if the user is already logged in (see #2071). While chatting can still be done via the Enter key, the disabled button is redundant since the text input box is already blocked when the user is not logged in. This unnecessary check has been removed to address this bug.
Does this introduce a breaking change?
When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.
Does this require changes to learn.microsoft.com docs?
This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.
Type of change
Code quality checklist
See CONTRIBUTING.md for more details.
python -m pytest).python -m pytest --covto verify 100% coverage of added linespython -m mypyto check for type errorsruffandblackmanually on my code.